fix: explain C99 assembly-catalog part numbers in the not-found error (#390) - #415
Open
DPS0340 wants to merge 1 commit into
Open
fix: explain C99 assembly-catalog part numbers in the not-found error (#390)#415DPS0340 wants to merge 1 commit into
DPS0340 wants to merge 1 commit into
Conversation
Progress on tscircuit#390. C9900033429 (the reported part) is a JLCPCB assembly-catalog number: both the EasyEDA search API and the products API return nothing for it (verified 2026-07-24 — every search list empty, products API 404), so the converter genuinely has nothing to fetch. The bare 'Component not found' error now identifies C99-prefixed assembly parts and suggests searching the underlying manufacturer part number, and the generic error includes the part number that failed.
Author
|
@Abse2001 same for this one if you have a minute — it's a one-message error-text change. Fixes #390. When a part number resolves to an assembly-catalog-only entry (the CI green, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #390 — makes the failure explainable instead of a dead end.
Investigation
C9900033429(the reported part) is a JLCPCB assembly-catalog part number. Verified against both EasyEDA API paths on 2026-07-24 (details in my issue comment):/api/components/search, whatfetchEasyEDAComponentuses): 0 results in every list (lcsc/easyeda/SMT/…)/api/products/C9900033429/components):{success:false, code:404}So the converter genuinely has nothing to fetch — the failure is correct, but the bare
"Component not found"gives the user no way to understand or work around it.Change
C99\d{6,}-prefixed parts get a specific error: identifies the number as a JLCPCB assembly-catalog entry that frequently has no EasyEDA symbol/footprint, and suggests searching the underlying manufacturer part number instead.Verification
fetchseam (no network): C99 part → assembly-catalog message; other part → generic message with part numbertests/fetch-testssuite: 9 pass, 0 failbunx tsc --noEmit/biome check— clean